adds Open In Cloudshell to all READMEs with one depth #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
force-pushed
the
add-open-in-cloudshell-button
branch
from
db21538 to
d78bfc3
Compare
bshaffer
force-pushed
the
add-open-in-cloudshell-button
branch
from
d78bfc3 to
78b5d03
Compare
bshaffer
force-pushed
the
add-open-in-cloudshell-button
branch
from
78b5d03 to
6704f5b
Compare
tmatsuo
reviewed
Jan 26, 2018
auth/README.md
Outdated
| [![Open in Cloud Shell][shell_img]][shell_link] | ||
|
|
||
| [shell_img]: http://gstatic.com/cloudssh/images/open-btn.png | ||
| [shell_link]: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googlecloudplatform/php-docs-samples&page=editor&working_dir=auth&open_in_editor=README.md |
Contributor
There was a problem hiding this comment.
I tried the link. There are basically 4 panes; file list, editor, instruction pane on the right, the shell at the bottom. I have feedback:
- The editor and the instruction pane both shows the same file, but with the different format. I feel it's redundant.
- The README is not perfect for this use case, the step for cloning the repo is redundant
- Cloudshell doesn't have composer
Can we
- Create a specialized readme file for this purpose and show it?
- Can we install composer by default in the cloudshell environment?
Contributor
Author
There was a problem hiding this comment.
-
If we remove "open_in_editor", it displays just the rendered README as expected, which I think should suffice. I'll get to updating that.
-
Agreed that we need
composerin the cloud shell environment, and that it is a requirement for this PR. I'll get started on this.
bshaffer
force-pushed
the
add-open-in-cloudshell-button
branch
from
ff2498d to
f30f836
Compare
bshaffer
force-pushed
the
add-open-in-cloudshell-button
branch
from
f30f836 to
7acbc42
Compare
Contributor
Author
|
This PR is dependent on composer being added to CloudShell, and CloudShell being upgraded to PHP 7.0. |
Contributor
Author
|
Composer has been added to Cloud Shell and PHP has been upgraded to 7.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#493