Skip to content

BigQuery: rewrite simple app tutorial. #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bshaffer merged 2 commits into from
Dec 15, 2017
Merged

BigQuery: rewrite simple app tutorial. #515

bshaffer merged 2 commits into from
Dec 15, 2017

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Dec 14, 2017

  • Use latest version of google/cloud-bigquery package.
  • Add additional region tags to support tutorial rewrite.
  • Use more relevant query from public datasets.
  • Use more direct associative array for printing results.

@tswast
BigQuery: rewrite simple app tutorial.
8d6e5a0 
- Use latest version of `google/cloud-bigquery` package.
- Add additional region tags to support tutorial rewrite.
- Use more relevant query from public datasets.
- Use more direct associative array for printing results.
@tswast tswast requested a review from bshaffer December 14, 2017 17:25
@tswast tswast mentioned this pull request Dec 14, 2017
Merged
bshaffer
bshaffer approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you Tim!

@bshaffer bshaffer merged commit 7203f3a into master Dec 15, 2017
@bshaffer bshaffer deleted the bq-simple-app branch December 15, 2017 21:29
@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 5, 2018

The test for this PR skipped the test for bigquery/stackoverflow:

+grep -q '^bigquery/stackoverflow'
+echo 'Skipping tests in bigquery/stackoverflow\n'
Skipping tests in bigquery/stackoverflow\n
+continue
+read DIR

I encounter the error when I try to fix the test failure in #530

@tswast
Copy link
Contributor Author

tswast commented Jan 5, 2018

Any guesses as to why that would be? I don't think I did anything special that it would skip it.

Also, note that this sample is already a few versions out of date. :-(

@tmatsuo
Copy link
Contributor

tmatsuo commented Jan 5, 2018

Yeah it's not your fault, but I think the script for skipping the irrelevant tests have a bug :(
I'm updating the client lib versions in #530

@tmatsuo tmatsuo mentioned this pull request Jan 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @tmatsuo @bshaffer