Add PHP 7.2 support for IAP #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR is dependent on #543 for tests to pass |
ryanmats
approved these changes
Jan 24, 2018
Contributor
ryanmats
left a comment
ryanmats
left a comment
There was a problem hiding this comment.
Looks good if the tests pass and you can explain the $signature_index variable.
iap/src/validate_jwt.php
Outdated
| $iap_jwt, | ||
| $jwk_set, | ||
| ['ES256'], | ||
| $signature_index |
Contributor
There was a problem hiding this comment.
what is this variable and where is it coming from?
Contributor
Author
There was a problem hiding this comment.
Yep! It's kinda silly, but if the validation is successful, it returns the index in the $jwk_set that is used by the key. Since it's not important to our sample, and it's optional, I'll remove it.
bshaffer
force-pushed
the
iap-for-php7_2
branch
from
2ae433d to
944f96f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PHP 7.2 support to IAP samples by using a different JWT library which supports PHP 7.2