adds compute engine logging sample #59
Conversation
bshaffer
force-pushed
the
gce-logging
branch
3 times, most recently
from
59986d4 to
e49b01d
Compare
|
Is it worthwhile to add a test? |
|
Yeah, I'll add a mock test |
|
@tmatsuo PTAL |
compute/logging/phpunit.xml
Outdated
| --> | ||
| <phpunit bootstrap="test/bootstrap.php"> | ||
| <testsuites> | ||
| <testsuite name="PHP twilio test"> |
There was a problem hiding this comment.
Name: PHP GCE logging test
| </testsuites> | ||
| <logging> | ||
| <log type="coverage-clover" target="../../../build/logs/clover-gce-logging.xml"/> | ||
| </logging> |
There was a problem hiding this comment.
I don't think I need to whitelist anything, since there's only index.php, which gets tested.
There was a problem hiding this comment.
Sorry for not explaining why. We should mark which files to measure the coverage. Otherwise phpunit thinks it should measure the coverage for everything including under vendor directory and we'll have very low coverage report :)
There was a problem hiding this comment.
I noticed there was a 30% decrease in coverage without this
Whitelist has been added!
|
LGTM |
compute/logging/phpunit.xml
Outdated
| </testsuite> | ||
| </testsuites> | ||
| <logging> | ||
| <log type="coverage-clover" target="../../../build/logs/clover-gce-logging.xml"/> |
There was a problem hiding this comment.
I think it should be ../../build/logs/clover-gce-logging.xml.
There was a problem hiding this comment.
ahh darn, good catch
|
Oh wait. The compute/index.php is not in the list on coveralls. Probably because it uses a wrong clover log file path. |
|
LGTM On Fri, Apr 15, 2016, 1:22 PM Coveralls [email protected] wrote:
|
3 participants
No description provided.