Skip to content

Remove F2 instance classes as F1s work great #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 2 commits into from
Aug 10, 2018
Merged

Remove F2 instance classes as F1s work great #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f28dc77
fixes getting-started tests
bshaffer Aug 10, 2018
ac3b36a
removes F2 instance classes
bshaffer Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion appengine/php72/getting-started/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# complete list of `app.yaml` directives.

runtime: php72
instance_class: F2

env_variables:
GOOGLE_STORAGE_BUCKET: ""
Expand Down
1 change: 1 addition & 0 deletions appengine/php72/getting-started/test/DeployTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ private static function beforeDeploy()

$appYaml = Yaml::parse(file_get_contents($tmpDir . '/app.yaml'));
$appYaml['env_variables']['GOOGLE_STORAGE_BUCKET'] = $bucketName;
$appYaml['env_variables']['CLOUDSQL_CONNECTION_NAME'] = $connection;
$appYaml['env_variables']['CLOUDSQL_USER'] = $dbUser;
$appYaml['env_variables']['CLOUDSQL_PASSWORD'] = $dbPass;
$appYaml['env_variables']['CLOUDSQL_DATABASE_NAME'] = $dbName;
Expand Down
1 change: 0 additions & 1 deletion appengine/php72/grpc/app.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
runtime: php72
instance_class: F2

handlers:
- url: /
Expand Down