Skip to content

[KMS] Remove global location from kms example to generalize for GCS #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 1 commit into from
Aug 13, 2018
Merged

[KMS] Remove global location from kms example to generalize for GCS #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kms/src/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@
* "serviceAccount:$serviceAccountEmail"
* @param string $role Must be in the format "roles/$role",
* "organizations/$organizationId/roles/$role", or "projects/$projectId/roles/$role"
* @param string $locationId [optional]
* @param string $locationId
* @return null
*/
function add_member_to_cryptokey_policy($projectId, $keyRingId, $cryptoKeyId, $member, $role, $locationId = 'global')
function add_member_to_cryptokey_policy($projectId, $keyRingId, $cryptoKeyId, $member, $role, $locationId)
{
// Instantiate the client, authenticate, and add scopes.
$client = new Google_Client();
Expand Down