-
Notifications
You must be signed in to change notification settings - Fork 1k
Add 8 BigQuery Load samples #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bshaffer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than fixing the usage text, this looks great. You could even do something like this for the usage:
return printf("Usage: php snippets/%s PROJECT_ID DATASET_ID\n", __FILE__);Other thoughts, if you want to get rid of the snippets directory and move them into the main folder, be my guest.
| // Include Google Cloud dependendencies using Composer | ||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
| if (count($argv) != 3) { | ||
| return print("Usage: php snippets/import_from_storage.php PROJECT_ID DATASET_ID\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be import_from_storage_orc.php
| // Include Google Cloud dependendencies using Composer | ||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
| if (count($argv) != 4) { | ||
| return print("Usage: php snippets/import_from_storage.php PROJECT_ID DATASET_ID TABLE_ID\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be import_from_storage_truncate.php
| // Include Google Cloud dependendencies using Composer | ||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
| if (count($argv) != 3) { | ||
| return print("Usage: php snippets/import_from_storage.php PROJECT_ID DATASET_ID\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be import_from_storage_autodetect.php
| // Include Google Cloud dependendencies using Composer | ||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
| if (count($argv) != 4) { | ||
| return print("Usage: php snippets/import_from_storage.php PROJECT_ID DATASET_ID TABLE_ID\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be import_from_storage_csv_truncate.php
| // Include Google Cloud dependendencies using Composer | ||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
| if (count($argv) != 3) { | ||
| return print("Usage: php snippets/import_from_storage.php PROJECT_ID DATASET_ID\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be import_from_storage_csv_autodetect.php
| // Include Google Cloud dependendencies using Composer | ||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
| if (count($argv) != 4) { | ||
| return print("Usage: php snippets/import_from_storage.php PROJECT_ID DATASET_ID TABLE_ID\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be import_from_storage_orc_truncate.php
| // Include Google Cloud dependendencies using Composer | ||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
| if (count($argv) != 3) { | ||
| return print("Usage: php snippets/import_from_storage.php PROJECT_ID DATASET_ID\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be import_from_storage_parquet.php
| // Include Google Cloud dependendencies using Composer | ||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
| if (count($argv) != 4) { | ||
| return print("Usage: php snippets/import_from_storage.php PROJECT_ID DATASET_ID TABLE_ID\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be import_from_storage_parquet_truncate.php
Adds the following samples: