Updates error reporting samples and fixes tests #802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bshaffer
commented
Jan 2, 2019
bshaffer
commented
- Removes a bunch of samples and simplifies them
- Fixes tests
grayside
reviewed
Jan 3, 2019
Contributor
grayside
left a comment
grayside
left a comment
There was a problem hiding this comment.
Cannot approve, there is a single missing whitespace. Good stuff.
Why is there a logger mechanism, a gRPC mechanism, but no REST client sample? Is that not an option?
| [0]: https://console.cloud.google.com/flows/enableapi?apiid=clouderrorreporting.googleapis.com | ||
| [1]: https://console.cloud.google.com/errors | ||
| [2]: https://console.cloud.google.com/iam-admin/serviceaccounts/ | ||
| [3]: http://php.net/manual/en/function.set-exception-handler.php |
| "google/cloud-error-reporting": "^0.8", | ||
| "symfony/console": " ^3.3", | ||
| "symfony/event-dispatcher": "^3.3" | ||
| "google/cloud-error-reporting": "^0.12.3" |
| private function verifyReportedError($projectId, $message, $retryCount = 6) | ||
| private function verifyReportedError($projectId, $message) | ||
| { | ||
| $retryCount = 7; |
Contributor
There was a problem hiding this comment.
Why bump to 7? Retry count seems arbitrary.
Contributor
Author
There was a problem hiding this comment.
It was failing occasionally when retryCount was 6. I guess the eventual consistency was around there. Would maybe be "better" to override the exponential backoff function, but given the context this is fine.
grayside
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.