[Cloud Tasks] Add HTTP task sample #866
Conversation
googlebot
added
the
cla: yes
averikitsch
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
grayside
left a comment
grayside
left a comment
There was a problem hiding this comment.
Overall the changes look good, but similar to my feedback for GoogleCloudPlatform/golang-samples#799, with this new feature not being App Engine-specific we should either move this to a top-level tasks/ directory or split it between /appengine/tasks and /tasks.
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
The README needs fixing, otherwise this looks great!
tasks/phpunit.xml.dist
Outdated
| @@ -0,0 +1,31 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| Copyright 2018 Google LLC. | |||
There was a problem hiding this comment.
nit: 2019! And should be for all new files!
tasks/README.md
Outdated
|
|
||
| First, your project ID: | ||
|
|
||
| export PROJECT_ID=my-project-id |
There was a problem hiding this comment.
Setting environment variables for PROJECT_ID, LOCATION_ID, and QUEUE_ID are not required, as we pass them into the script directly. The only environment variable required should be GOOGLE_APPLICATION_CREDENTIALS
|
Thanks for the review. Can I go ahead and merge? |
|
Looks great!! Thank you! |
5 participants
Test projects will have to be granted permission for HTTP targets or wait until whitelisting is off.