Skip to content

Fix signUrl readme and cs #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 3 commits into from
Apr 16, 2019
Merged

Fix signUrl readme and cs #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3824790
Update README.md
bshaffer Apr 16, 2019
8aefa4f
Update signUrlTest.php
bshaffer Apr 16, 2019
27907cf
Update signUrlTest.php
bshaffer Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions cdn/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@ The provided file includes implementation of base64url encode and decode functio

## Usage

```
<?php
require_once 'signUrl.php';
$base64url_key = 'wpLL7f4VB9RNe_WI0BBGmA=='; // head -c 16 /dev/urandom | base64 | tr +/ -_
$signed_url = signUrl('https://example.com/foo', 'my-key', $base64url_key, time() + 1800);
echo $signed_url;
?>
```php
require_once 'signUrl.php';
$base64url_key = 'wpLL7f4VB9RNe_WI0BBGmA=='; // head -c 16 /dev/urandom | base64 | tr +/ -_
$signed_url = signUrl('https://example.com/foo', 'my-key', $base64url_key, time() + 1800);
echo $signed_url;
```
5 changes: 2 additions & 3 deletions cdn/test/signUrlTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

use PHPUnit\Framework\TestCase;

require_once __DIR__."/../signUrl.php";
require_once __DIR__ . "/../signUrl.php";

class signUrlTest extends TestCase
{
Expand Down Expand Up @@ -54,8 +54,7 @@ public function testSignUrl()
"https://www.example.com/some/path?some=query&another=param&Expires=1549751461&KeyName=my-key&Signature=sTqqGX5hUJmlRJ84koAIhWW_c3M="),
);

foreach($cases as $c)
{
foreach ($cases as $c) {
$this->assertEquals(sign_url(https://github.com/$c[0],%20$c[1],%20$encoded_key,%20$c[2]), $c[3]);
}
}
Expand Down