Skip to content

Conversation

@jkwlui
Copy link
Collaborator

@jkwlui jkwlui commented May 10, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2019
@jkwlui jkwlui changed the title Storage: v4 signed url sample Add Storage v4 signed url samples May 10, 2019
@jkwlui jkwlui requested review from bshaffer and frankyn May 10, 2019 21:57
@jkwlui jkwlui self-assigned this May 10, 2019
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jkwlui could you update the README to reflect the CLI changes?

@jkwlui jkwlui requested review from frankyn and removed request for bshaffer May 13, 2019 19:45
@jkwlui jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2019
@jkwlui
Copy link
Collaborator Author

jkwlui commented May 14, 2019

Updated!

Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change to tests otherwise looks great!

@bshaffer bshaffer merged commit 33b3fe9 into master May 17, 2019
@bshaffer bshaffer deleted the v4-signed-url-samples branch May 17, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants