Moves Flex helloworld to this repo #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bshaffer
force-pushed
the
flex-helloworld
branch
from
0339677 to
0a4ed63
Compare
bshaffer
changed the title
tmatsuo
approved these changes
Aug 6, 2019
Contributor
tmatsuo
left a comment
tmatsuo
left a comment
There was a problem hiding this comment.
I thought you migrated other app to a framework other than silex, should you do the same for this app? It can come with a future PR though.
Contributor
Author
|
Agreed about updating from Silex. I have a PR which updates the Bookshelf to be Lumen. We should upgrade all Silex as well with a future PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GoogleCloudPlatform/getting-started-php#205