Refactors bigtable tests to use base trait #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Member
billyjacobson
left a comment
billyjacobson
left a comment
There was a problem hiding this comment.
Thanks so much for doing this, was thinking my code reuse was getting a bit out of hand :)
| ]); | ||
| } | ||
|
|
||
| public static function createDevInstance($instanceIdPrefix) |
Member
There was a problem hiding this comment.
Could we have this check an environment variable for an instance to use and if that is set return that instance id instead? Would make it so much easier to deal with with testing locally. Also, if that variable is used then, it shouldn't delete the instance, but should delete the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.