Create the Scarce-Ones Variant

[Gingy-120]

Creates the Scarce-Ones variant, where there is one fewer 1 in every suit. Will close #2994.

[Gingy-120]

Hmm I don't think the pull request got linked to the relevant open issue... here it is.

#2994

[Gingy-120]

@Zamiell is running a test game the only thing left to do here? I cannot get it to work at the moment but I am willing to try a bit more. Or perhaps @timotree3 could help, if he has a server able to run.

[Zamiell]

1. yes, please test it so make sure it works.
2. don't include any of the variants, only the base scare ones.
3. you don't need timo, you can just run a test game on your computer.

[Zamiell]

any update on this?

[Gingy-120]

I will attempt to test this some time this week.

How should I do this such that it implements only the base Scarce Ones? I followed the directions for "creating a variant", which asked me to create mixes with the other variants. It appears that this mix creation step is vital to even getting the base case into the list of allowed variants.

[vEnhance]

I made a few updates to this pull request:

• Since Inverted got merged, I regenerated the ID numbers so that they don't conflict
• Made prettier pass

I also briefly ran a test game on my local and it seems to be working okay --- Scarce Ones & Dark Pink has a 50-card deck as expected (5x9+5=50), and after discarding a 1 somewhere the other 1's show up as critical. Not extensive testing but passes a sanity check.

@Zamiell, I feel like we may as well add in Scarce Ones plus the standard variants? I feel like if we're going to have Scarce Ones at all, then something like Scarce Ones & Rainbow is fine. We have the same thing for Critical Fours, I feel like we should be consistent.

[Gingy-120]

Thanks so much @vEnhance!

[Zamiell]

I feel like we may as well add in Scarce Ones plus the standard variants? I feel like if we're going to have Scarce Ones at all, then something like Scarce Ones & Rainbow is fine. We have the same thing for Critical Fours, I feel like we should be consistent.

fine

[Zamiell]

lets hold off on this PR for now until inverted is accepted

[vEnhance]

lets hold off on this PR for now until inverted is accepted

Inverted is already accepted, right?

[Zamiell]

negative, it is still in a trial period and might be denied

[vEnhance]

Ah, okay. I'll just wait for you to merge then when you feel ready (well, if Inverted gets denied eventually let me know so I can regen the ID's for this PR so we don't have gaps).