code-server 4.1.0

[jsjoeio]

Created with brew bump-formula-pr.

[jsjoeio]

Notes

Trying to understand what's actually wrong.

Logs: https://github.com/Homebrew/homebrew-core/runs/5425429238?check_suite_focus=true

Error: 2 failed steps!
brew install --only-dependencies --verbose --build-bottle code-server
brew install --verbose --build-bottle code-server

Having a hard time seeing what the actual error is 🤔

The only thing I see in brew install --only-dependencies --verbose --build-bottle code-server is this:

  You can try again using:
    brew postinstall python@3.10
  Warning: The post-install step did not complete successfully

That's the only thing suspicious I see in the logs. The only other warning is this:

  Warning: HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK is set: not checking for outdated
  dependents or dependents with broken linkage!

So I'm really not too sure what the error is. It's strange because we didn't have these issues last release and we didn't have any major changes 🤔

And then in brew install --verbose --build-bottle code-server I see this:

 Logs:
       /Users/brew/actions-runner-x86_64/_work/homebrew-core/homebrew-core/bottles/logs/code-server/00.options.out
       /Users/brew/actions-runner-x86_64/_work/homebrew-core/homebrew-core/bottles/logs/code-server/01.yarn
  READ THIS: https://docs.brew.sh/Troubleshooting
  
  Error: code-server 4.1.0 did not build

I'm not sure why it's saying it didn't build?

[jsjoeio]

so it's only failing on arm...I think we had to manually fix this last time: https://github.com/Homebrew/homebrew-core/pull/92582/files

Shouldn't these changes have made it into homebrew from that PR? 🤔 Maybe the brew-bump-formula used an older commit?

Nevermind, they're there.

[jsjoeio]

Hmm maybe related to this? coder/code-server#4896 or parcel-bundler/watcher#93

[jsjoeio]

It seems like brew or something is swallowing the logs so I can't see the actual errors. I downloaded the logs but there's nothing in there either

[cho-m]

I am guessing a Homebrew CI issue, but will need someone else to take a look at ARM runners. There are some other PRs failing without logs and/or failing on postinstall.

[jsjoeio]

Now it's passing? 🤷‍♂️ That's magical lol yay!

[cho-m]

Some notes for Linux build to be explored outside this PR.

For Linux (not yet bottled, so ignored in CI), looks like there are a number of linked system libraries, which are mostly from electron.

Not sure if there is a way around this to allow us to package code-server for Linuxbrew. I guess an option would be to introduce an electron@13 and hack the build to pick that up, similar to what ArchLinux does for code.

We do update the RPATH to $ORIGIN:@@HOMEBREW_PREFIX@@/lib but there is a linkage issue with libX11.so.6, so it isn't using our libx11 formula dependency.

---

Missing libraries:
  unexpected (libX11.so.6)
  unexpected (libXcomposite.so.1)
  unexpected (libXdamage.so.1)
  unexpected (libXext.so.6)
  unexpected (libXfixes.so.3)
  unexpected (libXrandr.so.2)
  unexpected (libasound.so.2)
  unexpected (libatk-1.0.so.0)
  unexpected (libatk-bridge-2.0.so.0)
  unexpected (libatspi.so.0)
  unexpected (libc.musl-x86_64.so.1)
  unexpected (libcairo.so.2)
  unexpected (libcups.so.2)
  unexpected (libdrm.so.2)
  unexpected (libgbm.so.1)
  unexpected (libgdk-3.so.0)
  unexpected (libgdk_pixbuf-2.0.so.0)
  unexpected (libgtk-3.so.0)
  unexpected (libnspr4.so)
  unexpected (libnss3.so)
  unexpected (libnssutil3.so)
  unexpected (libpango-1.0.so.0)
  unexpected (libsmime3.so)
  unexpected (libxcb.so.1)
  unexpected (libxkbcommon.so.0)
  unexpected (libxshmfence.so.1)
Unwanted system libraries:
  /lib/x86_64-linux-gnu/libdbus-1.so.3

[BrewTestBot]

🤖 A scheduled task has triggered a merge.

[jsjoeio]

Not sure if there is a way around this to allow us to package code-server for Linuxbrew. I guess an option would be to introduce an electron@13 and hack the build to pick that up, similar to what ArchLinux does for code.

I was talking to @code-asher about this. We used to exclude electron entirely since we don't use it. It somehow got added back in (we believe by accident from another maintainer).

We plan to revisit this in a future version of code-server (possibly removing electron/x11 dependencies in a build step) to avoid this.