-
Notifications
You must be signed in to change notification settings - Fork 188
Replacing google poly integration with Icosa Gallery integration #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 3cea842.
This reverts commit 8bae0a6.
Note: The code for this commit was generated by one or more AI tools: probably Github Copilot (GPT-5 Mini?) and potentially also Claude Code CLI (Sonnet 4.5?).
By @DougReeder Why: Icosa doesn't have the rate limits that YouTube has. The original comment contained useful context.
Why: to match pretty-printing standard
# Conflicts: # lib/ret/media_search.ex # lib/ret_web/controllers/page_controller.ex
…atted' Why: Ensures dependencies are up-to-date, which the caching cannot.
Why: to eliminate code smell and ease debugging
|
We'd like to fix the "Server authenticity is not verified since certificate path validation is not enabled" in the reticulum log, but we don't yet know how. The ... appears to cover all the requirements to authenticate the host, but the message still appears. It's not impossible that the old version of Changing However, the An image you can install on your instance is available from https://hub.docker.com/ : dougreeder/reticulum:icosa-cleanup-2-2025-12-10-20-15 |
Why: returns potentially useful info on failures
Exairnous
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge/cleanup seems good and everything appears functional. As to the server authenticity issue, it feels to me like the path validation stuff isn't being applied to the right place, but I tried putting it in HTTPoison.head and retry_get_until_success in resolve_non_video but that didn't change the warning either.
While adding a new warning isn't ideal, since it appears everything works, and otherwise the code seems fine, I'm okay with merging this.
What?
Adds support for open-source Icosa Gallery, including redirects for CORS requests
Cleaned-up version of #723
Why?
Google Poly was shut down years ago, but Icosa Gallery makes the models there available via the Internet Archive. Unfortunately, one or more HTTP redirects is required to access the models on archive.org, and the existing reticulum code to make CORS requests for the Hubs client did not support that. Efforts to change parameters to enable support for redirects using the existing code were not successful, so LLM-generated code was added to manually follow redirects. That code is used by all CORS requests.
Icosa Gallery also allows new model submissions, which work without support for redirects.
Examples
How to test
Documentation of functionality
Should be functional identical to Sketchfab.
Hubs-Foundation/hubs-docs#235 will contain actual hubs-docs changes
Limitations
Presumably does not support pasting an Icosa Gallery page into Hubs.
When the Hubs client is updated to support Icosa Gallery, a separate reticulum PR will be required to support that.
Alternatives considered
It's likely a skilled Elixir programmer could implement redirects using less code.
Open questions
Additional details or related context
This PR is needed by the Spoke commit: Hubs-Foundation/Spoke#1301