Improve bootstrap's script handling of dependencies and related documentation #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 10, 2025 13:01
boostrap.py uses Popen to invoke readelf, git and tar. Add checks to ensure they are installed to avoid runtime failure.
Wrap subprocess.check_called with try / except and handle failures with CalledProcessError.
aperezdc
approved these changes
May 9, 2025
spenap
commented
May 9, 2025
ruby-getoptlong and ruby-erb are needed on Arch
This was referenced May 27, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies needed to run
bootstrap.pyare not listed in README, and are only apparent after running the script.This PR addresses that by making them explicit, bailing out earlier if not available.
Additionally, by handling subprocess errors with
try - except, subsequent errors raised by Cerbero are also easier to spot (and address).I noticed part of this had been raised as an issue in #172 , so this PR closes it.