Performance degradation fix due to rect tracking #2112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
May 13, 2025
igordmn
reviewed
May 13, 2025
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/node/RootNodeOwner.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/node/RootNodeOwner.skiko.kt
Show resolved
Hide resolved
Benchmarks are public, we refer them in public materials. But ok. |
pjBooms
force-pushed
the
pjBooms/rect-tracking-fix
branch
from
1ebc738 to
0b5aa1f
Compare
- added forgotten rect manager method calls in analogy of AndroidComposeView (from AOSP Change-Id: Ibcedf1aa6b2e96c5f11221248fa16fe1f82b9ba)
igordmn
approved these changes
May 14, 2025
pjBooms
force-pushed
the
pjBooms/rect-tracking-fix
branch
from
6c1c8a1 to
b58144d
Compare
pjBooms
added a commit
that referenced
this pull request
May 15, 2025
Added forgotten `RectManager` methods calls in analogy of AndroidComposeView (from AOSP [commit](androidx@655aebc)) Fixes: - [CMP-6925](https://youtrack.jetbrains.com/issue/CMP-6925) - [CMP-6715](https://youtrack.jetbrains.com/issue/CMP-6715) ## Testing Running the benchmark to ensure that degradation has done ## Release Notes ### Fixes - Multiple Platforms - Fixed a memory leak and performance degradation when `ComposeUiFlags.isRectTrackingEnabled` set to `true`(default).
Kpotko
added a commit
that referenced
this pull request
May 20, 2025
#2123) Added forgotten `RectManager` methods calls in analogy of AndroidComposeView (from AOSP [commit](androidx@655aebc)) Fixes: - [CMP-6925](https://youtrack.jetbrains.com/issue/CMP-6925) - [CMP-6715](https://youtrack.jetbrains.com/issue/CMP-6715) ## Testing Running the benchmark to ensure that degradation has gone ## Release Notes ### Fixes - Multiple Platforms - Fixed a memory leak and performance degradation when `ComposeUiFlags.isRectTrackingEnabled` set to `true`(default).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added forgotten
RectManagermethods calls in analogy of AndroidComposeView (from AOSP commit)Fixes:
Testing
Running the benchmark to ensure that degradation has done
Release Notes
Fixes - Multiple Platforms
ComposeUiFlags.isRectTrackingEnabledset totrue(default).