Simplify the CfW API for navController-browser navigation binding #2189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function can have fewer parameters: it doesn't need to have a `window` parameter, because it's a singleton, and we can access it implicitly.
MatkovIvan
reviewed
Jun 23, 2025
There was a problem hiding this comment.
@eymar please track this change on YT and add labal that it requires Documentation update
terrakok
approved these changes
Jun 23, 2025
`js(...)` is not available in shared k/js and k/wasm source sets
|
@MatkovIvan could you please review the new API? Need 2 approvals for API changes. |
MatkovIvan
approved these changes
Jun 23, 2025
navigation/navigation-runtime/src/jsMain/kotlin/androidx/navigation/BrowserHistory.js.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function can have fewer parameters: it doesn't need to have a
windowparameter, because it's a singleton, and we can access it implicitly.This change simplifies the
fun maincommon code (k/js and k/wasm), since no need to access w3cwindowAPI on the client side.Fixes: https://youtrack.jetbrains.com/issue/CMP-8427
Release Notes
Features - Navigation
NavController-suspend fun NavController.bindToBrowserNavigation. And the existing functionsuspend fun Window.bindToNavigationis deprecated now.