Implement scroll to focused interop views #2228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazunin-v-jb
approved these changes
Jul 11, 2025
svastven
reviewed
Jul 11, 2025
|
|
||
| } | ||
|
|
||
| private fun iterateAccessibilityElementHierarchy( |
There was a problem hiding this comment.
since this returns a boolean would it be more suitable to call it something like findInAccessibilityElementHierarchy or isInAccessibilityElementHierarchy ?
There was a problem hiding this comment.
Thanks for pointing. I believe the naming is correct since this is the primary action of the function, and considering the implementation, the full name should be something like iterateAccessibilityElementHierarchyAndVerifyElementInCurrentHierarchy()
I added the documentation to make it clear what the method actually does.
svastven
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
UIAccessibilityElementFocusedNotificationinstead of the private methodaccessibilityScrollToVisibleas a source of accessibility scroll.Refactor
InteropWrappingViewto support accessibility focus beyond bounds.Fixes https://youtrack.jetbrains.com/issue/CMP-7999/Autoscroll-does-not-work-when-accessibility-focuses-on-interop-views
Release Notes
Features - iOS