Fix Context menu items configuration in JS target #2296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schahen
reviewed
Aug 7, 2025
|
|
||
| internal actual fun Clipboard.isWriteSupported(): Boolean = | ||
| js("window.navigator.clipboard && (window.navigator.clipboard.write || window.navigator.clipboard.writeText)") | ||
| js("Boolean(window.navigator.clipboard && (window.navigator.clipboard.write || window.navigator.clipboard.writeText))") |
There was a problem hiding this comment.
this is js target - why we need this js wrapper and not acessing this entities directly? They are not declared in the stdlib?
There was a problem hiding this comment.
they are not nullable in kotlin.
And checking if a function is present or not is not possible in kotlin code, unless casting to dynamic.
Schahen
approved these changes
Aug 7, 2025
eymar
added a commit
that referenced
this pull request
Aug 7, 2025
Fixes https://youtrack.jetbrains.com/issue/CMP-8725 This code returns a "read" function(), not the boolean : ``` js("window.navigator.clipboard && window.navigator.clipboard.read") ``` but in the kotlin usage the returned value was compared with "true". And the comparison was false. For example `document.addEventListener == true` // false. ## Testing This should be tested by QA ## Release Notes ### Fixes - Web - _(prerelease fix)_ The context menu had only "Select All" item when targeting k/js
sekater
added a commit
that referenced
this pull request
Aug 7, 2025
Fixes https://youtrack.jetbrains.com/issue/CMP-8725 Cherry-picking #2296 ## Release Notes #2296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://youtrack.jetbrains.com/issue/CMP-8725
This code returns a "read" function(), not the boolean :
but in the kotlin usage the returned value was compared with "true". And the comparison was false. For example
document.addEventListener == true// false.Testing
This should be tested by QA
Release Notes
Fixes - Web