Skip to content

Conversation

svastven
Copy link

@svastven svastven commented Sep 17, 2025

Adds @Immutable annotation to PlatformImeOptionsImpl so Compose can treat instances as immutable and skip unnecessary input session restarts.

Fixes CMP-8917 [iOS] PlatformImeOptions - flickering keyboard

Testing

Adds test to ImeOptionsTest

This should be tested by QA

Release Notes

Fixes - iOS

  • Fix input session restarts triggered by PlatformImeOptionsImpl not being @Immutable.

Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this case?

@svastven svastven requested a review from MatkovIvan September 18, 2025 13:06
@svastven svastven merged commit eeb84f2 into jb-main Sep 18, 2025
13 checks passed
@svastven svastven deleted the svastven/bugfix/flickering-keyboard branch September 18, 2025 14:28
svastven added a commit that referenced this pull request Sep 18, 2025
Adds `@Immutable` annotation to `PlatformImeOptionsImpl` so Compose can
treat instances as immutable and skip unnecessary input session
restarts.

Fixes [CMP-8917](https://youtrack.jetbrains.com/issue/CMP-8917) [iOS]
PlatformImeOptions - flickering keyboard

Adds test to `ImeOptionsTest`

This should be tested by QA

- Fix input session restarts triggered by `PlatformImeOptionsImpl` not
being `@Immutable`.
svastven added a commit that referenced this pull request Sep 18, 2025
Adds `@Immutable` annotation to `PlatformImeOptionsImpl` so Compose can
treat instances as immutable and skip unnecessary input session
restarts.

Fixes [CMP-8917](https://youtrack.jetbrains.com/issue/CMP-8917) [iOS]
PlatformImeOptions - flickering keyboard

Adds test to `ImeOptionsTest`

This should be tested by QA

- Fix input session restarts triggered by `PlatformImeOptionsImpl` not
being `@Immutable`.
sekater added a commit that referenced this pull request Sep 29, 2025
) (#2417)

Adds `@Immutable` annotation to `PlatformImeOptionsImpl` so Compose can
treat instances as immutable and skip unnecessary input session
restarts.

Fixes [CMP-8917](https://youtrack.jetbrains.com/issue/CMP-8917) [iOS]
PlatformImeOptions - flickering keyboard

## Testing

Adds test to `ImeOptionsTest`

This should be tested by QA

## Release Notes
#2413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants