Skip to content

fix: trigger error hints on exception supertypes too #59843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: trigger error hints on exception supertypes too #59843

wants to merge 4 commits into from
+51 −11

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Oct 14, 2025 •
edited
Loading

Fixes #58367

@gdalle gdalle mentioned this pull request Oct 15, 2025
Open
@tecosaur
Copy link
Member

I'm afraid I can't offer a full review, but I do want to say that I love module Hinterland in the tests 😆

@DilumAluthge
Copy link
Member

@vtjnash Could you review this?

@DilumAluthge DilumAluthge assigned DilumAluthge and unassigned vtjnash Oct 15, 2025
@DilumAluthge DilumAluthge added the error messages Better, more actionable error messages label Oct 15, 2025
@DilumAluthge DilumAluthge requested a review from timholy October 15, 2025 16:26
@DilumAluthge
Copy link
Member

And maybe also @timholy?

@DilumAluthge DilumAluthge requested a review from vtjnash October 15, 2025 16:26
@gdalle
Copy link
Contributor Author

gdalle commented Oct 15, 2025

Crap, I struggled with the master build on my Mac so I didn't test locally but judging by CI it seems that

UndefVarError: `supertypes` not defined in `Base.Experimental`

which makes sense since supertypes comes from the InteractiveUtils stdlib. Is this approach doomed to fail?

@tecosaur
Copy link
Member

which makes sense since supertypes comes from the InteractiveUtils stdlib. Is this approach doomed to fail?

Not at all, you can still use supertype in a while loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timholy timholy Awaiting requested review from timholy

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees

@DilumAluthge DilumAluthge

Labels

error messages Better, more actionable error messages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define error hints for abstract exception types

4 participants

@gdalle @tecosaur @DilumAluthge @vtjnash