doc: fixing headings, mention in README.md, adding TailwindCSS steps #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
reviewed
May 29, 2020
Owner
Kocal
left a comment
Kocal
left a comment
There was a problem hiding this comment.
Thank you @spekulatius! It's look good to me, with few minor comments.
docs/development/TailwindCSS.md
Outdated
Comment on lines
34
to
55
| // Specify the paths to all of the template files in your project | ||
| content: ['./src/**/*.vue'], | ||
|
|
||
| // Include any special characters you're using in this regular expression | ||
| defaultExtractor: (content) => content.match(/[\w-/:]+(?<!:)/g) || [], | ||
|
|
||
| extractors: [ | ||
| // https://purgecss.com/guides/vue.html | ||
| { | ||
| extensions: ['vue'], | ||
| extractor(content) { | ||
| const contentWithoutStyleBlocks = content.replace(/<style[^]+?<\/style>/gi, ''); | ||
| return contentWithoutStyleBlocks.match(/[A-Za-z0-9-_/:]*[A-Za-z0-9-_/]+/g) || []; | ||
| }, | ||
| }, | ||
| ], | ||
|
|
||
| whitelist: [], | ||
| whitelistPatterns: [ | ||
| /-(leave|enter|appear)(|-(to|from|active))$/, // transitions | ||
| /data-v-.*/, // scoped css | ||
| ], |
docs/development/TailwindCSS.md
Outdated
| }); | ||
|
|
||
| module.exports = { | ||
| plugins: [tailwindcss(), ...(process.env.NODE_ENV === 'production' ? [purgecss] : [])], |
Contributor
Author
Ah, thanks for checking. Sorry, I've only copied it over and didn't check the indentation. It should be fixed now. |
Kocal
approved these changes
May 30, 2020
Kocal
changed the title
Owner
|
Thank you! |
Contributor
Author
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @Kocal
as promised some more tidy up on the documentation site. This includes:
If you think anything needs to be tweaked, just let me know and I'll do it before merging :)
Cheers,
Peter