-
Notifications
You must be signed in to change notification settings - Fork 665
add outputPath Config #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think there is still some misunderstanding here. The aim of add the setting Let me explain more about it: The setting of If the user set some values to it, for example: 'happy' then the file goes to the folder called Meanwhile, besides let the user customize the output folder, we will also provide some special values, which are, as you know, Do you get my point? |
Thank you very much, I have made changes. |
Thank you very much for these helpful suggestions. |
@@ -16,16 +17,17 @@ export async function showProblem(node?: LeetCodeNode): Promise<void> { | |||
if (!node) { | |||
return; | |||
} | |||
await showProblemInternal(node.id); | |||
await showProblemInternal(node); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though type casting from LeetCodeNode
to IProblem
is fine. Let's add getter in LeetCodeNode
to get the data, which is typed as IProblem
.
It looks like I need to do some refactors here later after this PR, The definition of
LeetCodeNode
andIProblem
is overlapped.
Add tag selector |
@ringcrl Looks much better now. I just did some changes and merged the PR. Thank you for your contribution. |
add outputPath config for leetcode #119
Change Request,Need Help...Find a way to get a Problem difficulty...