Hide deleted comments without children (fixes #3735)#3736
Merged
dessalines merged 2 commits intomainfrom Jan 7, 2026
Merged
Conversation
Nutomic
requested review from
SleeplessOne1917,
dessalines and
matc-pub
as code owners
dessalines
reviewed
Jan 5, 2026
| } = this.commentView; | ||
|
|
||
| // Hide deleted comment, unless it has children or was created by me. | ||
| const is_my_comment = |
Member
There was a problem hiding this comment.
There's already a get myComment function you can use.
Don't do an early return either, instead add this as an if condition on the <li element.
const isDeletedAndNoChildren = !myComment && deleted && childCount === 0;
...
(!isDeletedAndNoChildren && <li ...
dessalines
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After (without login):
