Post title on listing page should always open comments (fixes #3755)#3756
Merged
dessalines merged 1 commit intomainfrom Jan 15, 2026
Merged
Post title on listing page should always open comments (fixes #3755)#3756dessalines merged 1 commit intomainfrom
dessalines merged 1 commit intomainfrom
Conversation
Nutomic
requested review from
SleeplessOne1917,
dessalines and
matc-pub
as code owners
dessalines
reviewed
Jan 13, 2026
|
|
||
| return ( | ||
| <h1 className="post-name h5 d-inline text-break"> | ||
| {navigateExternal ? ( |
Member
There was a problem hiding this comment.
Just get of this function then, since its only used here.
Member
There was a problem hiding this comment.
Delete the navigateExternal function, its only used in one place, and now that's gone.
Member
Author
There was a problem hiding this comment.
Its not a function but a variable, and its already removed.
dessalines
approved these changes
Jan 15, 2026
|
|
||
| return ( | ||
| <h1 className="post-name h5 d-inline text-break"> | ||
| {navigateExternal ? ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.