Show SSO buttons on registration page (fixes #3285)#3808
Conversation
Nutomic
requested review from
SleeplessOne1917,
dessalines and
matc-pub
as code owners
| {this.registerForm()} | ||
| </div> | ||
| </div> | ||
| {(this.state.siteRes.oauth_providers?.length || 0) > 0 && ( |
There was a problem hiding this comment.
Isn't this equivalent to what's on the login.tsx page? Would be good to extract into a component.
|
|
||
| type OAuthLoginProps = { title: NoOptionI18nKeys }; | ||
|
|
||
| export default class OAuthLogin extends Component<OAuthLoginProps, object> { |
There was a problem hiding this comment.
If there's no state, then you don't need to use a class / inferno component, you can do a functional component IE export function OauthLogin({title}: OAuthLoginProps) {.... There are lots of these in the codebase.
There was a problem hiding this comment.
Also try to avoid using default, these become really annoying to trace down.
There was a problem hiding this comment.
Changed, although there are many other classes doing this.
|
Made these changes, and also changed it to use only a single string for signup/login. |
dessalines
left a comment
dessalines
left a comment
There was a problem hiding this comment.
Feel free to merge when you get conflicts.
|
Going to fix and merge this, because the removed translations is breaking other PRs. |
2 participants
LemmyNet/lemmy-translations#239