Updating to account for changed tag and sidebars.#3814
Merged
Conversation
Some logical changes were necessary, such as: - Removing markdowns forms and renderer for multi-community (it only has a summary) - Using summary instead of sidebar where it makes sense (like HtmlTags and document titles)
dessalines
requested review from
Nutomic,
SleeplessOne1917 and
matc-pub
as code owners
dessalines
commented
Jan 28, 2026
| return { | ||
| name: site.name, | ||
| description: site.description ?? "A link aggregator for the fediverse", | ||
| sidebar: site.sidebar ?? "A link aggregator for the fediverse", |
Member
Author
There was a problem hiding this comment.
This field seems unecessary, its just some untyped random thing in the manifest json, I'd be fine with removing it, or renaming it to summary and using the summary instead.
Member
There was a problem hiding this comment.
Description is part of the webmanifest standard, but sidebar is not.
Member
Author
|
Changed my mind, this should come before #3810 since the backend changes are already pushed to voyager.lemmy.ml |
Nutomic
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some logical changes were necessary, such as:
I'm not looking forward to the merge conflicts, so this should probably come after #3810