Merged
Conversation
Nutomic
requested review from
SleeplessOne1917,
dessalines,
dullbananas and
phiresky
as code owners
Nutomic
commented
Jun 11, 2025
|
|
||
| sql_fmt: | ||
| image: alpine:3 | ||
| image: *rust_image |
Member
Author
There was a problem hiding this comment.
Had to change this to have xargs -L available.
Member
There was a problem hiding this comment.
Weird that alpine doesn't support it, oh well.
Member
Author
There was a problem hiding this comment.
Alpine uses busybox, so the commands have much less parameters available. It would work but in my local testing it was much faster using -L
SleeplessOne1917
approved these changes
Jun 11, 2025
dessalines
approved these changes
Jun 11, 2025
|
|
||
| sql_fmt: | ||
| image: alpine:3 | ||
| image: *rust_image |
Member
There was a problem hiding this comment.
Weird that alpine doesn't support it, oh well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change sql formatting takes around 4s locally instead of 17s, and ci also gets faster.