Enable urlencoding for pictrs proxy parameter (fixes #5749)#5776
Merged
dessalines merged 1 commit intomainfrom Jun 11, 2025
Merged
Enable urlencoding for pictrs proxy parameter (fixes #5749)#5776dessalines merged 1 commit intomainfrom
dessalines merged 1 commit intomainfrom
Conversation
Nutomic
requested review from
SleeplessOne1917,
dessalines,
dullbananas and
phiresky
as code owners
Nutomic
commented
Jun 11, 2025
| format!("{}image/original?proxy={}", pictrs_config.url, encoded_url) | ||
| } else { | ||
| let file_type = file_type(params.file_type, url.as_str()); | ||
| let file_type = file_type(params.file_type, url.path()); |
Member
Author
There was a problem hiding this comment.
This was also wrong as it may include query params in the file type, so we explicitly need to use the path.
SleeplessOne1917
approved these changes
Jun 11, 2025
dessalines
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.