Implement multi-community search (fixes #5778)#5779
Merged
dessalines merged 3 commits intomulti-communityfrom Jun 12, 2025
Merged
Implement multi-community search (fixes #5778)#5779dessalines merged 3 commits intomulti-communityfrom
dessalines merged 3 commits intomulti-communityfrom
Conversation
Nutomic
requested review from
SleeplessOne1917,
dessalines,
dullbananas and
phiresky
as code owners
dessalines
reviewed
Jun 12, 2025
Member
dessalines
left a comment
dessalines
left a comment
There was a problem hiding this comment.
Feel free to merge after adding the title search
| .or(person::name.ilike(searcher.clone())) | ||
| .or(person::display_name.ilike(searcher.clone())); | ||
| .or(person::display_name.ilike(searcher.clone())) | ||
| .or(multi_community::name.ilike(searcher.clone())); |
Member
There was a problem hiding this comment.
Search the title also, like community does.
Member
Author
There was a problem hiding this comment.
Added title search, and description as well.
Nutomic
force-pushed
the
multi-community-search
branch
from
490692a to
afd2924
Compare
Nutomic
added a commit
that referenced
this pull request
Jun 17, 2025
* Implement multi-community (fixes #818, fixes #5340) * db methods * add api methods * ts opt * wip * sql queries * cleanup * wip: federation * query by name * add ap_id column * add read_apub, compiles now * validate multi-comm name * disallow removed, deleted, private * scheduled task * remove piefed test * resolve_object with workaround * review * avoid db read * api client * fix api test fetch * wip: test cases * wip * add max elements, array_remove comments * simplify post view query * mvoe structs * fix api test * fix api test * rename to suggested_communities, add api param * filter removed/deleted * check_api_elements_count * filter out removed/deleted during update * inner join * add listing type suggested * db schema changes * transaction * address some review comments * separate methods for create, delete entry * update js client * get multi * remove CommunityOrMulti * check helper, other stuff * fix api test * change get multi comm return type * Replace MultiCommunityView with GetMultiCommunityResponse * get rid of todo * add local column, admins can edit local multi-comm * implement multi-comm follow (db and api) * api for multi-comm follow * move and rename MultiCommunityApub * move multi-comm to apub-objects * move multi-comm url to top-level * list multi-comms followed by user * add todo * remove param * update local follows * update query * db functions and tests * cleanup * fix api test * add entry limit * rewrite links * federation changes * wip federation * simplify generate_activity_id * more wip * more wip * multi-comm follow * federate changes * cleanup * clippy * test fixes * fmt * fix * wip: update follows after federated multi-comm change * remove scheduled task * update follows after multi update * fmt * fixes * review comments * indexes * remove MultiCommunityApub * fix test * ts fix * review * db schema for local_site.multi_comm_follower * adjust code and tests * fixes * cleanup, comment * fix tests * fix * remove more test code * fix new install * add index * fix api tests * fix * remove index * more fix * Implement multi-community search (fixes #5778) (#5779) * Implement multi-community search (fixes #5778) * fixes * search title and description * MultiCommunityView * rename fields * revert test change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate PR so its a bit easier to review.