Replace most uses of context.reset_request_count() with clone()#5790
Merged
dessalines merged 5 commits intomainfrom Jun 16, 2025
Merged
Replace most uses of context.reset_request_count() with clone()#5790dessalines merged 5 commits intomainfrom
dessalines merged 5 commits intomainfrom
Conversation
Nutomic
force-pushed
the
replace-reset-request-count
branch
from
2ea5441 to
007be6d
Compare
Nutomic
requested review from
SleeplessOne1917,
dessalines,
dullbananas and
phiresky
as code owners
dessalines
approved these changes
Jun 16, 2025
Comment on lines
+20
to
+22
| [features] | ||
| full = [ | ||
| "lemmy_db_schema/full", |
Member
There was a problem hiding this comment.
I'm guessing this was needed because tests for this crate alone failed without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests all seem to be passing like this, only remaining use of
reset_request_count()is for settings import which may need to resolve a lot of objects, and for fetching community collections (moderators, featured posts). Of course production is different, so there may be other places which hit the limit with this change.