Fixing docker_update.sh script to not add context.#5820
Merged
Conversation
Use docker build from a higher level to not load massive context.
dessalines
requested review from
Nutomic,
SleeplessOne1917,
dullbananas and
phiresky
as code owners
dessalines
commented
Jun 23, 2025
| logging: *default-logging | ||
|
|
||
| lemmy: | ||
| image: dessalines/lemmy:1.0.0-alpha.4 |
Member
Author
There was a problem hiding this comment.
Not sure how this got added, but it meant no changes would ever get tested correctly in docker.
dessalines
commented
Jun 23, 2025
Member
Author
There was a problem hiding this comment.
Makes sense to add at least a template for this file. Devving and testing migrations pretty much requires it.
Nutomic
reviewed
Jun 24, 2025
| max_worker_processes = 16 | ||
| max_parallel_workers_per_gather = 4 | ||
| max_parallel_workers = 16 | ||
| max_parallel_maintenance_workers = 4 |
Member
There was a problem hiding this comment.
This looks specific to your machine and shouldnt be committed.
Member
Author
There was a problem hiding this comment.
It is, but the docker-compose.yml needs to mount this file, and it should be required for testing anyway. What if I just leave a comment at the top of this file linking how to generate it for your machine?
EDIT: did that
Nutomic
reviewed
Jun 24, 2025
| docker login --username="$DOCKER_USER" | ||
| fi | ||
|
|
||
| echo "$LOG_PREFIX Initializing images in the background. Please be patient if compiling from source..." |
Member
There was a problem hiding this comment.
Did you run a formatter on this? Maybe worth adding to ci.
Nutomic
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use docker build from a higher level to not load massive context.
Also formatted this file.