Auto-follow community when enabling notifications (fixes #6081)#6082
Merged
dessalines merged 3 commits intomainfrom Oct 16, 2025
Merged
Auto-follow community when enabling notifications (fixes #6081)#6082dessalines merged 3 commits intomainfrom
dessalines merged 3 commits intomainfrom
Conversation
Nutomic
requested review from
SleeplessOne1917,
dessalines,
dullbananas and
phiresky
as code owners
Nutomic
force-pushed
the
notification-auto-follow-comm
branch
2 times, most recently
from
4b450f4 to
52a98bb
Compare
dessalines
approved these changes
Oct 15, 2025
dessalines
reviewed
Oct 15, 2025
Comment on lines
+29
to
+33
| pub(super) async fn do_follow_community( | ||
| community: Community, | ||
| person: &Person, | ||
| follow: bool, | ||
| context: &Data<LemmyContext>, |
Member
There was a problem hiding this comment.
Would probably be a good idea to pass in &Community, even if you do have to do a clone later. Up to you tho.
Member
Author
There was a problem hiding this comment.
Its not necessary as the callers dont use community anymore.
dessalines
approved these changes
Oct 15, 2025
Nutomic
force-pushed
the
notification-auto-follow-comm
branch
from
52a98bb to
baa6754
Compare
dessalines
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.