Skip to content

Fix for NodeBB compat and updated test assets#6090

Merged
dessalines merged 1 commit intomainfrom
deserialize-last-null
Oct 22, 2025
Merged

Fix for NodeBB compat and updated test assets#6090
dessalines merged 1 commit intomainfrom
deserialize-last-null

Conversation

@Nutomic
Copy link
Copy Markdown
Member

@Nutomic Nutomic commented Oct 17, 2025

Values "icon": null, "image": null were not handled correctly by deserialize_last.

LemmyNet/activitypub-federation-rust#151

@Nutomic Nutomic force-pushed the deserialize-last-null branch from 1fc3e32 to f7c76ca Compare October 17, 2025 13:11
@Nutomic Nutomic changed the title Fix for NodeBB compat Fix for NodeBB compat and updated test assets Oct 17, 2025
@Nutomic Nutomic force-pushed the deserialize-last-null branch from f7c76ca to 9adc941 Compare October 17, 2025 13:11
@Nutomic Nutomic marked this pull request as ready for review October 17, 2025 13:12
lemmy_db_views_site = { version = "=1.0.0-alpha.9", path = "./crates/db_views/site" }
lemmy_db_views_vote = { version = "=1.0.0-alpha.9", path = "./crates/db_views/vote" }
activitypub_federation = { version = "0.7.0-beta.7", default-features = false, features = [
activitypub_federation = { git = "https://github.com/LemmyNet/activitypub-federation-rust.git", default-features = false, features = [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should do a release before merging.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont want to make new beta releases constantly which only contain a single change. Will make a release sometime before Lemmy 1.0 instead.

@dessalines dessalines merged commit 057d43c into main Oct 22, 2025
3 checks passed
@dessalines dessalines deleted the deserialize-last-null branch October 22, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants