Remove special BanFromCommunityResponse in favor of PersonResponse.#6113
Merged
Remove special BanFromCommunityResponse in favor of PersonResponse.#6113
Conversation
The site ban already returns PersonResponse now, this makes the BanFromCommunityResponse consistent to that.
dessalines
requested review from
Nutomic,
SleeplessOne1917,
dullbananas and
phiresky
as code owners
Member
|
This was mainly used to get the current ban value in the response which isnt included in the normal |
Member
Author
|
It isn't really, I stumbled upon this while working in lemmy-ui. When you call ban from community, you already have the banned boolean, so all the live page updates can assume that the ban went through. I do think overall its good to return the changed object, but for this one I think its better to be consistent and just have actions done on a person return a |
Nutomic
approved these changes
Oct 30, 2025
Member
|
Plus it simplifies the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site ban already returns PersonResponse now, this makes the BanFromCommunityResponse consistent to that.