Skip to content

Remove unused flags, add description #9854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 8, 2022

Conversation

LeoKuhorev
Copy link
Contributor

  • remove not applicable cmdlet parameters
  • add more detailed example description

@opbld32
Copy link

opbld32 commented Aug 30, 2022

Docs Build status updates of commit 40be7d2:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Get-CsTeamsMediaLoggingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Grant-CsTeamsMediaLoggingPolicy.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@yogkumgit yogkumgit self-assigned this Aug 31, 2022
@yogkumgit yogkumgit requested review from get-itips, dariomws and a user August 31, 2022 11:30
@yogkumgit
Copy link

@get-itips @dariomws @tseward

@dariomws
Copy link
Contributor

dariomws commented Aug 31, 2022

@LeoKuhorev, If you have a Microsoft alias, you can link your accounts in GitHub so that a blue "Microsoft submitter" label appears to any PR's or issue you submit. Guidance on it here: https://docs.opensource.microsoft.com/tools/github/index.html

Here is the site you can use to see the mappings between GitHub and Microsoft aliases: https://repos.opensource.microsoft.com/people?q=LeoKuhorev

Copy link
Contributor

@get-itips get-itips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also agree that if the parameter is still in the code we need to keep it in the documentation otherwise people open issues when they find it.

@get-itips
Copy link
Contributor

get-itips commented Aug 31, 2022

Checked with 4.6.1-preview are these parameters going to be removed soon?

@opbld32
Copy link

opbld32 commented Aug 31, 2022

Docs Build status updates of commit 10ba866:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Get-CsTeamsMediaLoggingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Grant-CsTeamsMediaLoggingPolicy.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@LeoKuhorev
Copy link
Contributor Author

Also agree that if the parameter is still in the code we need to keep it in the documentation otherwise people open issues when they find it.

It seems like those parameters are not implemented in neither this nor the other Grant-<...> cmdlets. And also they're not listed in other Grant-<..> cmdlets docs, so removing them here as well for consistency

@get-itips
Copy link
Contributor

@LeoKuhorev
Can you kindly specify against which version are you testing the existence of the parameters? Many thanks Leo

@LeoKuhorev
Copy link
Contributor Author

Initially I was using 4.5.0. I've just installed 4.6.1-preview, and it seems to be able to find the -Group parameter, but now it looks like TeamsMediaLoggingPolicy is not enabled in flighting for the Group Policy Assignment. Let me see if enabling it in flighting will resolve the issue. Thanks!

@yogkumgit
Copy link

@get-itips @dariomws @tseward

@get-itips
Copy link
Contributor

@yogkumgit please see #9854 (comment) as we are now waiting on some checks by @LeoKuhorev

@opbld31
Copy link

opbld31 commented Sep 1, 2022

Docs Build status updates of commit 9bb60d9:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Get-CsTeamsMediaLoggingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Grant-CsTeamsMediaLoggingPolicy.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@LeoKuhorev
Copy link
Contributor Author

After the flighting I confirmed that both -Group and -Rank parameters are working fine, so I'm bringing them back to docs as well as introducing a new example for the group policy assignment. Please take a look when you get a chance. Thanks!

@get-itips
Copy link
Contributor

@LeoKuhorev It would be good to bring those back in the same line numbers that were before, this helps later when looking at the file history (to understand nothing actually changed about those parameters)
Thanks for checking that

@dariomws
Copy link
Contributor

dariomws commented Sep 2, 2022

I agree with @get-itips, it would be great to have it.

@opbld33
Copy link

opbld33 commented Sep 6, 2022

Docs Build status updates of commit 4f405c2:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Get-CsTeamsMediaLoggingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Grant-CsTeamsMediaLoggingPolicy.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@LeoKuhorev
Copy link
Contributor Author

Want to provide some updates on group policy assignment. I sync'd with the infra team and it occurred that currently group assignment is fully available for 12 policies listed in the note section here. For other policies group assignment is only available for internal and TAP users. There's currently work going to extend the availability to general public.

Therefore, I'm removing reference to -Group and -Rank flags for now and will bring them back once group policy assignment is available for everyone.

Please review and let me know if you have any questions. Thanks!

@yogkumgit
Copy link

@get-itips

@yogkumgit
Copy link

@tiburd Please merge this PR. Thanks

@tiburd tiburd merged commit b39f294 into MicrosoftDocs:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants