-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove unused flags, add description #9854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LeoKuhorev
commented
Aug 30, 2022
- remove not applicable cmdlet parameters
- add more detailed example description
Docs Build status updates of commit 40be7d2: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@get-itips @dariomws @tseward |
@LeoKuhorev, If you have a Microsoft alias, you can link your accounts in GitHub so that a blue "Microsoft submitter" label appears to any PR's or issue you submit. Guidance on it here: https://docs.opensource.microsoft.com/tools/github/index.html Here is the site you can use to see the mappings between GitHub and Microsoft aliases: https://repos.opensource.microsoft.com/people?q=LeoKuhorev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also agree that if the parameter is still in the code we need to keep it in the documentation otherwise people open issues when they find it.
Checked with 4.6.1-preview are these parameters going to be removed soon? |
Docs Build status updates of commit 10ba866: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
It seems like those parameters are not implemented in neither this nor the other Grant-<...> cmdlets. And also they're not listed in other Grant-<..> cmdlets docs, so removing them here as well for consistency |
@LeoKuhorev |
Initially I was using 4.5.0. I've just installed 4.6.1-preview, and it seems to be able to find the |
@get-itips @dariomws @tseward |
@yogkumgit please see #9854 (comment) as we are now waiting on some checks by @LeoKuhorev |
…owershell into leokukharau/publicDocs
Docs Build status updates of commit 9bb60d9: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
After the flighting I confirmed that both |
@LeoKuhorev It would be good to bring those back in the same line numbers that were before, this helps later when looking at the file history (to understand nothing actually changed about those parameters) |
I agree with @get-itips, it would be great to have it. |
…owershell into leokukharau/publicDocs
Docs Build status updates of commit 4f405c2: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Want to provide some updates on group policy assignment. I sync'd with the infra team and it occurred that currently group assignment is fully available for 12 policies listed in the note section here. For other policies group assignment is only available for internal and TAP users. There's currently work going to extend the availability to general public. Therefore, I'm removing reference to Please review and let me know if you have any questions. Thanks! |
@tiburd Please merge this PR. Thanks |