Skip to content

Fix Identity Parameter for Remove cmdlet #9869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2022
Merged

Conversation

dandsm
Copy link
Contributor

@dandsm dandsm commented Sep 5, 2022

Parameter Identity referrers to a Policy Instance Name (XdsIdentity) for Remove Cmdlets

If users follow the current documentation and try to pass a UserId or UserEmail, the cmdlet will not work and will throw exceptions.

Identity Parameter for Remove-CsTeamsShiftsPolicy cmdlet referrers to the Policy Instance Name (XdsIdentity) that will be removed.
@opbld30
Copy link

opbld30 commented Sep 5, 2022

Docs Build status updates of commit 6135537:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Remove-CsTeamsShiftsPolicy.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review - @dandsm, kindly commit the minor suggested change. Many thanks.

@yogkumgit yogkumgit self-assigned this Sep 6, 2022
@dandsm
Copy link
Contributor Author

dandsm commented Sep 6, 2022

@JohanFreelancer9 committed your suggestion

@opbld32
Copy link

opbld32 commented Sep 6, 2022

Docs Build status updates of commit 0cef353:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Remove-CsTeamsShiftsPolicy.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@yogkumgit yogkumgit requested review from get-itips, a user and dariomws September 7, 2022 11:34
@yogkumgit
Copy link

@dariomws @get-itips @tseward

Copy link
Contributor

@get-itips get-itips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I could check and you are right about these changes, take a look at the comment about the param set, thanks again!

@dandsm
Copy link
Contributor Author

dandsm commented Sep 7, 2022

@get-itips Committed your suggestion

@opbld33
Copy link

opbld33 commented Sep 7, 2022

Docs Build status updates of commit 26248c7:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Remove-CsTeamsShiftsPolicy.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@yogkumgit
Copy link

@tiburd Please merge this PR. Thanks.

@tiburd tiburd merged commit 867decf into MicrosoftDocs:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants