Skip to content

Conversation

lunulae
Copy link
Contributor

@lunulae lunulae commented Feb 17, 2025

Trying to get this one out before September <3

Trying to get this one out before September <3
@Booplicate Booplicate added awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors priority: high labels Feb 17, 2025
@Booplicate
Copy link
Member

Saving us with this one lol

Copy link
Member

@Legendkiller21 Legendkiller21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial code review

@multimokia
Copy link
Member

Sticking a pin in this to review wait timings to get consistency going again

Co-authored-by: Legendkiller21 <[email protected]>
Co-authored-by: Spotted Dove <[email protected]>
@ThePotatoGuy ThePotatoGuy added this to the 0.12.16 milestone Mar 30, 2025
@ThePotatoGuy ThePotatoGuy changed the base branch from content to content-12 March 30, 2025 23:52
Copy link
Member

@Booplicate Booplicate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also add a new entry to the ANNI_LIST list. In the future we should make this process a little easier with some wrapper that will call the required functions for us, so we don't miss stuff like this.

Copy link
Member

@multimokia multimokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency sweep on waits

m 2ekb "I mean--{w=0.2}I don't want to assume!{w=0.3} But I was thinking about it earlier, and I wanted to tell you something."
m 2fkbsa "I wanted to tell you that it's been so exciting to watch you change."
m "In the time we've spent together, you've grown so much. You've gone through so many setbacks, but you survived every one."
m 2dkbsa "And yet,{w=0.2} with all of those changes you've been through..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
m 2dkbsa "And yet,{w=0.2} with all of those changes you've been through..."
m 2dkbsa "And yet,{w=0.1} with all of those changes you've been through..."

lunulae and others added 2 commits April 2, 2025 12:36
Co-authored-by: Totally a booplicate <[email protected]>
Co-authored-by: multimokia <[email protected]>
Copy link
Member

@multimokia multimokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eased some expressions here, feel free to test and see how they feel

@multimokia multimokia merged commit e1291e6 into content-12 May 9, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting code review someone needs to check for syntax/logic/indentation errors awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested priority: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants