Skip to content

Conversation

QiJune
Copy link
Collaborator

@QiJune QiJune commented Sep 10, 2025

Summary by CodeRabbit

  • Tests
    • Expanded pre-merge coverage for PyTorch workflows, adding scenarios for logit-bias in chat/completions across multiple samplers, BERT quickstart classification flows, and out-of-tree modeling. Improves confidence in critical inference paths.
    • Streamlined another test suite by removing overlapping or low-value cases related to the above scenarios, reducing CI time and potential flakiness without affecting product functionality.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@QiJune
Copy link
Collaborator Author

QiJune commented Sep 10, 2025

/bot run --stage-list "A30-PyTorch-1,A30-PyTorch-2"

Copy link
Contributor

coderabbitai bot commented Sep 10, 2025

📝 Walkthrough

Walkthrough

Two test list YAMLs were updated: l0_a30.yml adds seven PyTorch pre_merge tests; l0_l40s.yml removes several PyTorch pre_merge tests, including modeling and e2e/logit-bias cases. No structural or logic changes outside these lists.

Changes

Cohort / File(s) Summary of Changes
Add PyTorch pre_merge tests
tests/integration/test_lists/test-db/l0_a30.yml
Added seven entries under PyTorch pre_merge: modeling_out_of_tree; OpenAI logit-bias tests (torch_sampler, trtllm_sampler) for completions/chat; PTP quickstart BERT tests (VANILLA, TRTLLM).
Remove PyTorch pre_merge tests
tests/integration/test_lists/test-db/l0_l40s.yml
Removed PyTorch pre_merge entries: unittest/_torch/modeling (modeling_out_of_tree, modeling_mllama); OpenAI logit-bias tests (torch_sampler, trtllm_sampler) for completions/chat; PTP quickstart BERT (VANILLA, TRTLLM).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (2 passed, 1 warning)

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The current pull request description remains the unmodified template and lacks any concrete summary of the actual changes, explanation of the motivations, details of test coverage, or PR-specific checklist items, so it does not meet the repository’s description requirements. Please replace the placeholder template content with a filled‐out summary explaining which tests were moved and why, list the relevant test cases to verify the changes, and confirm completion of the PR checklist sections such as dependency scanning and documentation updates.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “[None][ci] move some test cases from l40s to a30” accurately follows the repository’s ticket/type template, clearly indicates that test entries are being relocated between the l40s and a30 test lists, and concisely summarizes the primary change without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9986070 and 6eaa988.

📒 Files selected for processing (2)
  • tests/integration/test_lists/test-db/l0_a30.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_l40s.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/test-db/l0_l40s.yml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/test-db/l0_a30.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/test_lists/test-db/l0_a30.yml (3)

28-29: PTP quickstart BERT tests on multiple device configs—confirm cache availability and pre-merge runtime budget.

Tests added in

  • tests/integration/test_lists/test-db/l0_a30.yml
  • tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml
  • tests/integration/test_lists/test-db/l0_gb202.yml

pull the HF model/dataset (bert-base-uncased-yelp-polarity). Ensure each device’s agent has the cache or fetch rights, and that running both VANILLA and TRTLLM variants across all configurations stays within the pre-merge SLA.


24-27: Logit-bias tests moved correctly to A30
Entries appear only in tests/integration/test_lists/test-db/l0_a30.yml (lines 24–27) and are absent from all L40 configs.


21-21: Drop not applied: modeling_mllama still present
The entry for modeling_mllama remains in tests/integration/test_lists/test-db/l0_l40s.yml (line 17), so it wasn’t removed and there’s no parity action needed in l0_a30.yml.

Likely an incorrect or invalid review comment.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18402 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18402 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #13803 (Partly Tested) completed with status: 'SUCCESS'

@QiJune QiJune requested a review from kaiyux September 10, 2025 22:55
@QiJune
Copy link
Collaborator Author

QiJune commented Sep 10, 2025

/bot skip --comment "A30 PyTorch pipelines passed"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #18413 [ skip ] triggered by Bot

@kaiyux kaiyux enabled auto-merge (squash) September 10, 2025 23:08
@tensorrt-cicd
Copy link
Collaborator

PR_Github #18413 [ skip ] completed with state SUCCESS
Skipping testing for commit 6eaa988

@kaiyux kaiyux merged commit 656f229 into NVIDIA:main Sep 10, 2025
8 of 9 checks passed
Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025
MrGeva pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants