Skip to content

Only update metrics if not already updating metrics #9142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benaadams merged 1 commit into from
Aug 16, 2025
Merged

Only update metrics if not already updating metrics #9142

benaadams merged 1 commit into from
Aug 16, 2025

Conversation

@benaadams
Copy link
Member

@benaadams benaadams commented Aug 15, 2025 •
edited
Loading

Changes

  • Only start metrics updating if prior has completed
  • Fast reflection accessor
  • Get Db metrics out of flow of regular metrics so they don't block metric updates

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams requested a review from kamilchodola August 15, 2025 15:14
@benaadams benaadams force-pushed the update-metrics-one-at-a-time branch from 7d26a30 to e59f6c0 Compare August 16, 2025 10:19
@benaadams
Only update metrics if not already updating metrics
7572e51 
Better metric updating

Fast Reflection Accessor

Also name other compiled Expressions
@benaadams benaadams force-pushed the update-metrics-one-at-a-time branch from e59f6c0 to 7572e51 Compare August 16, 2025 10:19
@benaadams benaadams merged commit 49169bf into master Aug 16, 2025
195 of 200 checks passed
@benaadams benaadams deleted the update-metrics-one-at-a-time branch August 16, 2025 11:44
benaadams added a commit that referenced this pull request Aug 16, 2025
@benaadams
Only update metrics if not already updating metrics (#9142)
a8ecee9 
Better metric updating

Fast Reflection Accessor

Also name other compiled Expressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asdacap asdacap asdacap approved these changes

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

Assignees

No one assigned

Labels

performance is good

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benaadams @asdacap