Skip to content

Fix snap sync edge case due to unnecessary proof #9166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benaadams merged 1 commit into from
Aug 19, 2025
Merged

Fix snap sync edge case due to unnecessary proof #9166

benaadams merged 1 commit into from
Aug 19, 2025

Conversation

@asdacap
Copy link
Contributor

@asdacap asdacap commented Aug 19, 2025

  • Fix snap sync edge case where sometimes the server give unnecessary proof where the proof given is the same as the only slot which causes the proof node marked as IsBoundaryProof to not be saved.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Running some more sync.

@benaadams benaadams merged commit feebdb9 into master Aug 19, 2025
79 checks passed
@benaadams benaadams deleted the fix/snap-sync-edge-case branch August 19, 2025 15:22
benaadams pushed a commit that referenced this pull request Aug 19, 2025
@asdacap @benaadams
Fix snap sync edge case due to unnecessary proof (#9166)
0bc7a05 
Fix snap sync edge case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benaadams benaadams benaadams approved these changes

Assignees

No one assigned

Labels

bug fix + reliability

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asdacap @benaadams