Skip to content

Conversation

@asdacap
Copy link
Contributor

@asdacap asdacap commented Aug 20, 2025

  • Explicitly pass parent header in header validator.
    • Otherwise previously it will use BlockHeader.MaybeParent, which is just too implicit or _blockTree.FindHeader.
  • Effect block validator as well.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Mainnet can sync normally.
  • Mainnet era replay runs fine.

@asdacap asdacap mentioned this pull request Aug 20, 2025
7 tasks
@asdacap asdacap merged commit 48e8a47 into master Aug 21, 2025
78 checks passed
@asdacap asdacap deleted the refactor/explicit-parent-header branch August 21, 2025 08:11
@LukaszRozmej LukaszRozmej mentioned this pull request Sep 5, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants