Fix transaction processed counter not working #9270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public void OnBeforeTxExecution(Transaction transaction) | ||
| { | ||
| _currentBlockState?.IncrementTransactionCounter(); |
Contributor
Author
There was a problem hiding this comment.
The IsToBeWarmedWorldState make sure that this is the main tx processing one. So it just need to increment the number.
| private bool _isInScope = false; | ||
| private readonly ILogger _logger; | ||
| private PreBlockCaches? PreBlockCaches { get; } | ||
| public bool IsToBeWarmedWorldState { get; } |
Member
There was a problem hiding this comment.
Suggested change
| public bool IsToBeWarmedWorldState { get; } | |
| public bool WarmWorldState { get; } |
Or PopulateCaches
Or Enabled
asdacap
commented
Sep 11, 2025
|
|
||
| public void OnBeforeTxExecution(Transaction transaction) | ||
| { | ||
| _currentBlockState?.IncrementTransactionCounter(); |
Contributor
Author
There was a problem hiding this comment.
The IsToBeWarmedWorldState make sure that this is the main tx processing one. So it just need to increment the number.
| } | ||
| } | ||
|
|
||
| public class PrewarmerTxAdapter(ITransactionProcessorAdapter baseAdapter, BlockCachePreWarmer preWarmer, IWorldState worldState) : ITransactionProcessorAdapter |
LukaszRozmej
approved these changes
Sep 11, 2025
| { | ||
| PreBlockCaches Caches { get; } | ||
| bool IsToBeWarmedWorldState { get; } | ||
| bool IsWarmWorldState { get; } |
Member
There was a problem hiding this comment.
Not proper english? WarmWorldState would be better? But we are i IPreBlockCaches I would like the name not to contain WorldState if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransactionProcessedfield and used a prewarmer specific decorator instead.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing