Make eth_getBlobsV1 return UnsupportedFork post Osaka #9341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
commented
Sep 23, 2025
|
|
||
| public Task<ResultWrapper<IEnumerable<BlobAndProofV1?>>> HandleAsync(byte[][] request) | ||
| { | ||
| if (chainHeadSpecProvider.GetCurrentHeadSpec().IsEip7594Enabled) |
Member
Author
There was a problem hiding this comment.
Is this best way to check for Osaka here?
|
|
||
| Metrics.GetBlobsRequestsSuccessTotal++; | ||
| return ResultWrapper<IEnumerable<BlobAndProofV2>?>.Success(response.ToList()); | ||
| return ResultWrapper<IEnumerable<BlobAndProofV2>?>.Success(response); |
Member
Author
There was a problem hiding this comment.
You can put disposables into response and they will be disposed.
Btw this wasn't disposed on success earlier at all!
marcindsobczak
approved these changes
Sep 23, 2025
stdevMac
pushed a commit
that referenced
this pull request
Sep 25, 2025
* Make eth_getBlobsV1 return UnsupportedFork post Osaka * whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?