Fix beneficiary & blob base fee in eth_simulate #9371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Sep 28, 2025
asdacap
reviewed
Sep 29, 2025
| .AddDecorator<IBlockhashProvider, SimulateBlockhashProvider>() | ||
| .AddDecorator<IVirtualMachine, SimulateVirtualMachine>() | ||
| .AddDecorator<IBlockValidator, SimulateBlockValidatorProxy>() | ||
| .AddSingleton<ITransactionProcessor, SimulateTransactionProcessor>() |
Contributor
There was a problem hiding this comment.
Got a solution that does not involve a subclass of SimulateTransactionProcessor? This will break plugins that override ITransactionProcessor. Perhaps some kind gas calculator interface maybe?
Contributor
Author
There was a problem hiding this comment.
I would move all virtual functions into an interface, but it's overkill probably
| : TransactionProcessorBase(specProvider, worldState, virtualMachine, codeInfoRepository, logManager); | ||
| : TransactionProcessorBase(gasCalculator, specProvider, worldState, virtualMachine, codeInfoRepository, logManager); | ||
|
|
||
| public class GasCalculator : ITransactionProcessor.IGasCalculator |
Member
There was a problem hiding this comment.
Maybe better BaseFeeCalculator? It is not calculating gas per se.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
eth_simulateV1/ethSimulate-blobs (nethermind)Set beneficiary as parent beneficiary.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
Documentation
Requires documentation update
Requires explanation in Release Notes