Try fixing leak in ProtocolsManager._sessions #9410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should we check it on @smartprogrammer93 node? |
Member
Author
|
Maybe lets merge it, I don't think it will break anything |
benaadams
approved these changes
Oct 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fix memory/session leak in ProtocolsManager._sessions by reordering cleanup and adding null guards in SessionDisconnected.
- Remove session from _sessions earlier in the method
- Add null checks and reorder cleanup for satellite protocols and tx pool peers
stdevMac
pushed a commit
that referenced
this pull request
Oct 29, 2025
* Try fixing leak in ProtocolsManager._sessions * Additional check for safety * Avoid double removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing