Improve Block related caching

[benaadams]

Changes

• More reduced version of Improve Block caching and reduce lookup allocations #8943
• Introduce block hash -> block number cache
• Don't update ClockCache concurrent dictionary if value the same
• Don't update cache in Block/Header finder if it came from cache in first place
• Use smaller keys for Block and Header cache

Types of changes

What types of changes does your code introduce?

• Optimization

Testing

Requires testing

• No

[Copilot]

Pull Request Overview

This PR optimizes block-related caching mechanisms in Nethermind by introducing a hash-to-number cache, preventing unnecessary cache updates, and using more efficient cache keys.

Key changes:

• Introduces a dedicated Hash256AsKey cache for block hash to block number mappings
• Adds cache update avoidance logic in ClockCache when values are identical
• Tracks whether data came from cache via fromCache parameter to prevent redundant cache operations
• Replaces ValueHash256 with Hash256AsKey for more efficient cache key storage

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
Nethermind.Taiko/L1OriginStore.cs	Updates database lookup to use Hash256 instead of ValueHash256
Nethermind.Serialization.Rlp/KeyValueStoreRlpExtensions.cs	Adds fromCache output parameter and refactors cache lookup logic to use Hash256AsKey
Nethermind.Facade/Simulate/SimulateDictionaryHeaderStore.cs	Implements fromCache tracking for simulated header store
Nethermind.Facade/Simulate/SimulateDictionaryBlockStore.cs	Implements fromCache tracking for simulated block store
Nethermind.Core/KeyValueStoreExtensions.cs	Updates key generation methods to use in ValueHash256 for better performance
Nethermind.Core/Caching/ClockCache.cs	Adds value comparison logic to avoid updating cache when value is unchanged
Nethermind.Blockchain/Headers/IHeaderStore.cs	Adds fromCache output parameter to Get method signature
Nethermind.Blockchain/Headers/HeaderStore.cs	Implements hash-to-number cache and integrates fromCache tracking
Nethermind.Blockchain/Blocks/IBlockStore.cs	Adds fromCache output parameter to Get method signature
Nethermind.Blockchain/Blocks/BlockStore.cs	Implements fromCache tracking and uses Hash256AsKey for cache
Nethermind.Blockchain/BlockTree.cs	Uses fromCache to conditionally cache headers and blocks
Nethermind.Blockchain.Test/Blocks/HeaderStoreTests.cs	Changes test variable declarations to use interface type

[Copilot]

Pull Request Overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

[LukaszRozmej]

Could we add:

• ParentHash to the cache where we have blocks and numbers.
• On Head change actively scan through cache, double check and ensure we have all the items for Blockhash opcode? (unless a long reorg you won't actually hit DB!)

[benaadams]

Made new bugs :(

[benaadams]

• On Head change actively scan through cache, double check and ensure we have all the items for Blockhash opcode? (unless a long reorg you won't actually hit DB!)

Not sure how this would help? (adding 256 blockhash refreshes to every block)