Block caching #9572

kamilchodola · 2025-10-27T09:44:57Z

Fixes Closes Resolves #

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

List the changes

Types of changes

What types of changes does your code introduce?

Bugfix (a non-breaking change that fixes an issue)
New feature (a non-breaking change that adds functionality)
Breaking change (a change that causes existing functionality not to work as expected)
Optimization
Refactoring
Documentation update
Build-related changes
Other: Description

Testing

Requires testing

Yes
No

If yes, did you write tests?

Yes
No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

Yes
No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

Yes
No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

* Test * Test * Try fix * Delegation in GetCachedCodeInfo * Do not trace delegate call * Fix known-failing-tests.txt * Fix suggestions

Removed known failing tests related to eth_getBlockByNumber.

* fix: Use correct Docker Hub secrets across workflows * Update release workflow --------- Co-authored-by: Ruben Buniatyan <[email protected]>

Co-authored-by: rubo <[email protected]>

* Fix: Blocktest validation bypass and exception handling logic This commit addresses two critical issues in blockchain test validation: 1. Validation Bypass Vulnerability: - Removed the `!test.SealEngineUsed ||` condition that allowed blocks to skip validation entirely when using NoProof seal engine - Now all blocks undergo proper consensus rule validation regardless of seal engine type (seal validation itself remains conditional) 2. Inverted Exception Logic: - Fixed inverted null checks on `ExpectedException` in both validation failure and exception handling paths - Added explicit validation pass/fail checks to catch blocks that unexpectedly pass when they should fail - Improved error messages to include actual validation error details - Added explanatory comments documenting expected behavior The validation framework now correctly: - Validates all blocks through the consensus rule validator - Fails tests when blocks unexpectedly pass validation - Fails tests when blocks unexpectedly fail validation - Properly handles expected failures via both validation and exceptions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * ExpectException asserts simplification * fixes * Remove SealEngineType and SealEngineUsed * simplify asserts * Fix expectsException --------- Co-authored-by: Bhargava Shastry <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Alexey Osipov <[email protected]>

Co-authored-by: emlautarom1 <[email protected]>

* initial * format * apply comments * update description * remove leading zeros from some places * update known-failing-hive-tests.txt after running the hive

* Update send blobs docs and fix an option * Fix dockerfile

… activation (#9506)

#9507) * Add CancelAfter to Maintain_correct_pointers_for_beacon_sync_in_archive_sync * add Retry * try fix combines_contract_and_local_data_correctly

disable osaka chiado hardfork Co-authored-by: Marc Harvey-Hill <[email protected]>

* xdc block sealer * Test * Format

* Do not load nonce from state * Prepare state before assembling body * Emulate nonce overflow * known-failing-tests * Fix suggestions * test * Fix * MixHash & types & remove mod * fxi

Co-authored-by: rubo <[email protected]>

@LukaszRozmej

* Update CryptoRandom.cs * Create CryptoRandomTests.cs * Update src/Nethermind/Nethermind.Crypto/CryptoRandom.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Apply suggestion from @LukaszRozmej --------- Co-authored-by: Lukasz Rozmej <[email protected]>

…orrectly (#9511)

* Preparation for log-index * PR cleanup * Move Merge to separate interface * PR feedback # Conflicts: # src/Nethermind/Nethermind.Db/LogIndex/LogIndexStorage.cs * Receipts events renaming # Conflicts: # src/Nethermind/Nethermind.Facade/Find/LogIndexBuilder.cs * PR feedback * Formatting * Code cleanup * Code cleanup * Fix DB config validation * Use sorted view instead of iterator # Conflicts: # src/Nethermind/Nethermind.Db/LogIndex/LogIndexStorage.cs * Do not publicly expose iterator * Code cleanup * Revert changes to DB config reading * PR feedback * PR feedback * PR feedback # Conflicts: # src/Nethermind/Nethermind.Db.Rocks/Config/DbConfig.cs # src/Nethermind/Nethermind.Db.Rocks/Config/IDbConfig.cs * PR feedback

…n issues (#9536) * Initial plan * Add state persistence after genesis loading - Call CommitTree(0) after successful genesis processing to force persist state to disk - Add comprehensive tests for GenesisLoader state persistence behavior - Ensures genesis state is available on restart after unclean shutdown Co-authored-by: asdacap <[email protected]> * Fix code formatting for GenesisLoaderTests Co-authored-by: asdacap <[email protected]> * Use IWorldStateManager.FlushCache() for genesis state persistence - Changed GenesisLoader constructor to take IWorldStateManager instead of IWorldState - Call FlushCache(CancellationToken.None) after successful genesis processing - Removed test file as requested - This uses the proper abstraction for cache flushing as suggested by reviewer Co-authored-by: asdacap <[email protected]> * Inject worldstate and flush after scope exit * Add comprehensive unit tests for GenesisLoader - Test successful genesis loading triggers FlushCache - Test timeout scenario does not trigger FlushCache - Test invalid block scenario does not trigger FlushCache - Test FlushCache is called after scope exit - All 4 new tests pass, total 24 tests in Consensus.Test Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: asdacap <[email protected]> Co-authored-by: Amirul Ashraf <[email protected]>

* fix leading zero issue * add new test * use Hash256 instead of ValueHash256

#9542)

…9388) * Add support for block producer based on global world state instance. * Register ProducedBlockSuggester * Add config. Suggest produced block and update main chain. * Added test * Small refactor

Co-authored-by: Ruben Buniatyan <[email protected]>

* PoC of delayed sending if requested * Add retry cache * Fix logs and multiple requests expiration * Add tests * Rename * Add more tests * Improve * Simplify dependencies * Improve * Rename * no requestoor draft * Use messages * Remove the requestoor * Fix tests * Fix tests * More fixes * Substitute * Disconnect peers with invalid txs * Update src/Nethermind/Nethermind.Network.Contract/Messages/IResourceRequestMessage.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Compress code * Try pooled set * Handle as eth66 * Fix review * Fix tests * No need in syncing handling * Remove redundant dispose * Review --------- Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Ben {chmark} Adams <[email protected]>

* implement XdcBlockStore * Add XdcBlockStore and XdcHeaderStore * ws fix * Apply suggested changes * primary constructor --------- Co-authored-by: ak88 <[email protected]>

proper fix for key property in storage proof. revert change to ValueHash256Converter.cs to always return leading zeros.

* implement pool for timeouts and votes * implement timeout handler * use XdcPool for collecting timeouts * implement checks before timeout handling and refactors * update tc manager in tests * expose OnReceiveTimeout method in interface for tc manager * bit of optimization * format --------- Co-authored-by: ak88 <[email protected]>

* implement pool for timeouts and votes * remove unnecessary array allocation * merged --------- Co-authored-by: ak88 <[email protected]> Co-authored-by: ak88 <[email protected]>

* initial draft implementation of EpochSwitchInfoManager * refactor and fix build issues * added some tests * refactor to use IXdcReleaseSpec * fix build issue * refactors and tests and fixes * refactors and fixes and more tests * fixes, add missing field, refactor tests * refactor tests to be more predictable and consistent * ws fixes * fix issues * refactors and applying suggeted changes * fix test * apply Math.Max suggestion * refactors and suggetions * remove redundent method * fix failing tests * refactor Spec moq-ing * cleanup and ws fixes * cleanup * cleanup * modify calls to epochSwitch mgr methods --------- Co-authored-by: ak88 <[email protected]> Co-authored-by: Carmen Irene Cabrera Rodríguez <[email protected]> Co-authored-by: cicr99 <[email protected]>

* Update CODEOWNERS with project owners * Update .github/CODEOWNERS * Update .github/CODEOWNERS * Update .github/CODEOWNERS * Update CODEOWNERS * Update .github/CODEOWNERS * Update .github/CODEOWNERS * Update .github/CODEOWNERS --------- Co-authored-by: Alexey Osipov <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]>

bump: nethermind version on props

* test changes for mainnet * fixing comments * remove unused method * rollback PersistentStorageProvider.cs - changes not needed * remove logs * remove unnecessary changes * remove unnecessary changes * virtual isGenesis on BlockHeader.cs * empty line * more places with hardcoded 0 for block or header number * small change * commit PR suggestion

* block producer * format * test * block production test * format * use the constant * use timestamp from attributes * default for timestamp * name * merged * merge fix

* PoC of delayed sending if requested * Add retry cache * Fix logs and multiple requests expiration * Add tests * Rename * Add more tests * Improve * Simplify dependencies * Improve * Rename * no requestoor draft * Use messages * Remove the requestoor * Fix tests * Fix tests * More fixes * Substitute * Disconnect peers with invalid txs * Update src/Nethermind/Nethermind.Network.Contract/Messages/IResourceRequestMessage.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Compress code * Try pooled set * Handle as eth66 * Fix review * Fix tests * No need in syncing handling * Validate sizes and types * Add a test * Fix test * Add tests * Fix test * Code style * Rollback * Fix tests * Move to proper class * Rollback that rollback * Mark not invalid txs as received * Move * Fix dispose * Fix * Moar * Clean up cache * Using --------- Co-authored-by: Lukasz Rozmej <[email protected]>

* use trace * if

Fix logs

* push draft implementation of QC manager and other related components * intial draft implementation of Votes manager * arg null exception * fixes * refactor and fixes * refactor * refactor * Change signatures * bit of refactor * cleanup * merged master * Test * format * fixes * format * format * persist when committing QC * merge conflicts * merge fixes * votepool type * concurrent vote pool * added log * isigner * comment * comments * implement initial vote filtering * refactor vote manager * implement XdcPool for votes and timeouts * ensure valid votes before processing qc * format * implement pool for timeouts and votes * add tests for vote handling * fix errors after merge * format * fix for QC manager * format * refactors and add tests --------- Co-authored-by: ak88 <[email protected]> Co-authored-by: cicr99 <[email protected]> Co-authored-by: Carmen Irene Cabrera Rodríguez <[email protected]>

Co-authored-by: emlautarom1 <[email protected]>

Co-authored-by: rubo <[email protected]>

* test * Error codes * Adjust errors * More error codes * Fix build * Fix tests * known failing tests * Move simulate error codes

deffrian and others added 30 commits October 17, 2025 21:03

Fix delegation in eth_simulate (#9490)

e715443

* Test * Test * Try fix * Delegation in GetCachedCodeInfo * Do not trace delegate call * Fix known-failing-tests.txt * Fix suggestions

Remove passing eth_getBlockByNumber hive tests (#9462)

d322c8a

Removed known failing tests related to eth_getBlockByNumber.

fix: Use correct Docker Hub secrets across workflows (#9495)

b214371

* fix: Use correct Docker Hub secrets across workflows * Update release workflow --------- Co-authored-by: Ruben Buniatyan <[email protected]>

Fix batched trie visitor missed storage (#9496)

f0f691b

Move static/trusted nodes file to the data dir (#9477)

71daec9

Update Dockerfiles (#9497)

ff7a10f

Co-authored-by: rubo <[email protected]>

Update OP Superchain chains (#9500)

c59d1e2

Co-authored-by: emlautarom1 <[email protected]>

Improve Hive RPC compat. (#9489)

e1f985d

* initial * format * apply comments * update description * remove leading zeros from some places * update known-failing-hive-tests.txt after running the hive

Update send blobs tool (#9472)

f01a49f

* Update send blobs docs and fix an option * Fix dockerfile

Make AuthorizationListForRpc.JsonConverter public for attribute-based…

0e5c541

… activation (#9506)

Add CancelAfter to Maintain_correct_pointers_for_beacon_sync_in_archi… (

b074856

#9507) * Add CancelAfter to Maintain_correct_pointers_for_beacon_sync_in_archive_sync * add Retry * try fix combines_contract_and_local_data_correctly

Disable osaka chiado hardfork (#9486)

e8b68ff

disable osaka chiado hardfork Co-authored-by: Marc Harvey-Hill <[email protected]>

Feature/xdc block sealer (#9505)

3890a14

* xdc block sealer * Test * Format

Use correct Bmi2 intrinsic support check (#9510)

9c1e3bc

Fix nonce handling in eth_simulate (#9499)

a49f56e

* Do not load nonce from state * Prepare state before assembling body * Emulate nonce overflow * known-failing-tests * Fix suggestions * test * Fix * MixHash & types & remove mod * fxi

Replace GitHub token (#9515)

43b458f

Fix fast sync settings workflow (#9519)

c331519

Auto-update fast sync settings (#9522)

60c1955

Co-authored-by: rubo <[email protected]>

Slight logging change (#9520)

b823f68

Remove overseer tests (#9527)

ccedb1c

fix: CompositeTxTracer aggregates IsTracingLogs and gates ReportLog c…

1e2e933

…orrectly (#9511)

Fix Leading Zero Issue for taiko (#9538)

1c57988

* fix leading zero issue * add new test * use Hash256 instead of ValueHash256

Fix incorrect BlockRangeUpdateMessage.EarliestBlock in some edge cases (

54de36c

#9542)

Add support for block producer based on global world state instance. (#…

6b9f037

…9388) * Add support for block producer based on global world state instance. * Register ProducedBlockSuggester * Add config. Suggest produced block and update main chain. * Added test * Small refactor

Remove Holesky (#9525)

cbe5569

Co-authored-by: Ruben Buniatyan <[email protected]>

rubo and others added 24 commits October 23, 2025 10:48

Improve build version handling (#9547)

e5f9e69

XDC : Add Header and Block Stores (#9528)

d05aef6

* implement XdcBlockStore * Add XdcBlockStore and XdcHeaderStore * ws fix * Apply suggested changes * primary constructor --------- Co-authored-by: ak88 <[email protected]>

proper fix for key property in storage proof for rpc-compat (#9551)

0e69c28

proper fix for key property in storage proof. revert change to ValueHash256Converter.cs to always return leading zeros.

Xdc Pool for timeouts and votes (#9521)

4bd692d

* implement pool for timeouts and votes * remove unnecessary array allocation * merged --------- Co-authored-by: ak88 <[email protected]> Co-authored-by: ak88 <[email protected]>

bump: nethermind version on props to 1.36.0 (#9556)

e87a1b0

bump: nethermind version on props

XDC block producer (#9512)

bc122a4

* block producer * format * test * block production test * format * use the constant * use timestamp from attributes * default for timestamp * name * merged * merge fix

Use trace instead of warn (#9563)

555a862

* use trace * if

Validate sizes and types (#9564)

6772637

Fix logs

Update OP Superchain chains (#9568)

5e6657d

Co-authored-by: emlautarom1 <[email protected]>

Auto-update fast sync settings (#9567)

3c234bc

Co-authored-by: rubo <[email protected]>

Fix simulate errors (#9565)

fbbf8a4

* test * Error codes * Adjust errors * More error codes * Fix build * Fix tests * known failing tests * Move simulate error codes

Don't recache if from cache

cf336f4

Improve ClockCache fast path

976d47b

Use smaller keys for Block and Header caches

af3f629

Pass via in

89ba8dc

Add number cache

54da9a9

formatting

65d7fc0

sp

920f256

kamilchodola marked this pull request as ready for review October 27, 2025 09:45

kamilchodola requested review from a team, LukaszRozmej, MarekM25 and rubo as code owners October 27, 2025 09:45

kamilchodola merged commit 2120f63 into kch/autotrace-with-blockhash Oct 27, 2025
221 of 223 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Block caching #9572

Block caching #9572

Uh oh!

kamilchodola commented Oct 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Block caching #9572

Block caching #9572

Uh oh!

Conversation

kamilchodola commented Oct 27, 2025

Changes

Types of changes

What types of changes does your code introduce?

Testing

Requires testing

If yes, did you write tests?

Notes on testing

Documentation

Requires documentation update

Requires explanation in Release Notes

Remarks

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants